[openib-general] Re: [PATCH] OpenSM - check port capabilities to create MC group-#2

[Hal Rosenstock]

Hi Yael,

On Sun, 2006-03-05 at 08:21, Yael Kalka wrote:
> Hi Hal,
> 
> This is the fixed patch (Sasha's comment).
> 
> After checking in Sasha's patch regarding the port capabilities for
> joining MC group, and doing some testing here, we've noticed the
> following problem:
> Currently, when requesting to create MC group with MTU(rate) selector
> 1 (meaning less than rate specified), the MC group is created with
> MTU(rate) requested - 1. This is without checking the MTU(rate) of the
> port requesting the creation of the multicast group. 
> This means that if, for example, port with MTU=2 sends a request for
> MC group creation with MTU selector=1 and MTU=5, Opensm will try to
> create a MC group with MTU=4, and fail, since the port capabilities
> are not realizable.
> The following patch adds creation of the MC group with MTU(rate) that
> also takes into account the MTU(rate) of the port requesting the creation.
> 
> Thanks,
> Yael
> 
> Signed-off-by:  Yael Kalka <yael at mellanox.co.il>

Thanks. Applied (to both trunk and 1.0 branch).

-- Hal