[openib-general] Re: [PATCH] Synchronize access to event list in uCM

Roland Dreier rdreier at cisco.com
Mon Mar 6 16:27:32 PST 2006


 > Fix synchronization around accessing event list.

 > +	down(&file->mutex);
 >  	if (!list_empty(&file->events))
 >  		mask = POLLIN | POLLRDNORM;
 > +	up(&file->mutex);

Actually, could you give a little more detail about why this is
needed, if only for the changelog?  I don't see what putting the mutex
around the list_empty() test buys you -- the list_empty() test already
is pretty atomic I think.

 - R.



More information about the general mailing list