[openib-general] Re: [PATCH] TX/RX_RING_SIZE as loadable parameters

[Roland Dreier]

 > diff -urN infiniband/ulp/ipoib/ipoib_ib.c 
 > infiniband-ring/ulp/ipoib/ipoib_ib.c
 > --- infiniband/ulp/ipoib/ipoib_ib.c     2006-03-03 13:57:18.000000000 
 > -0800

Your patch is line-wrapped and can't be applied :(

 > +extern int ipoib_rx_ring_size;
 > +extern int ipoib_tx_ring_size;

Please just add declarations to ipoib.h instead of putting this in
multiple .c files.

 > +module_param_named(rx_ring_size, ipoib_rx_ring_size, int, 0);
 > +MODULE_PARM_DESC(rx_ring_size, "change rx_ring_size");
 > +module_param_named(tx_ring_size, ipoib_tx_ring_size, int, 0);
 > +MODULE_PARM_DESC(tx_ring_size, "change tx_ring_size");

The permissions on these parameters might as well be 0444 so that the
settings are readable after the fact.

Also the parameter descriptions should probably be something more
descriptive like "Number of entries in receive/transmit ring".

Other than that it looks pretty good.

Thanks,
  Roland