[openib-general] [PATCH] mthca - read byte count & read request size

[Moni Levy]

On 3/7/06, Roland Dreier <rdreier at cisco.com> wrote:
>    Grant> Why is this an enum?
>
>    >> +static int pcix_max_rbc = PCIX_MAX_RBC_INVALID;
>
>    Grant> It's declared an int and is "user visible".  I think the
>    Grant> user interface would be better served if the user could
>    Grant> just specify "pcix_max_rbc=2048" instead of some magic
>    Grant> value.
>
> Yes, makes sense, and any invalid value (including a default value of
> say 0) would mean for the driver to ignore the module parameter.

Maybe a message to the syslog can inform the user that his value was
ignored in order to spare false assumptions.

- Moni

>  - R.
> _______________________________________________
> openib-general mailing list
> openib-general at openib.org
> http://openib.org/mailman/listinfo/openib-general
>
> To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
>