[openib-general] Re: [PATCH] TX/RX_RING_SIZE as loadable parameters

Roland Dreier rdreier at cisco.com
Tue Mar 7 08:42:17 PST 2006


    Michael> These parameters must be a power of 2, and at least 2,
    Michael> otherwise things break. I'd suggest making these a log
    Michael> and multiplying the result by 2, to exclude the
    Michael> possibility of user error.

Yes, good point.  However I think the value the user passes in should
be the log base 2 of the ring size -- multiplying by an extra factor
of 2 is too confusing (who would ever expect to pass in 5 to get a
ring size of 64?).  Just ignore the value if it's less than 1 or
bigger than say 12 or something like that.

 - R.



More information about the general mailing list