[openib-general] Re: [PATCH 8 of 20] ipath - sysfs support for core driver

[Roland Dreier]

 > +static ssize_t show_version(struct device_driver *dev, char *buf)
 > +{
 > +	return scnprintf(buf, PAGE_SIZE, "%s", ipath_core_version);
 > +}

Any reason you left a "\n" off of this attribute?

 > +static ssize_t show_atomic_stats(struct device_driver *dev, char *buf)
 > +{
 > +	memcpy(buf, &ipath_stats, sizeof(ipath_stats));
 > +
 > +	return sizeof(ipath_stats);
 > +}

I think putting a whole binary struct in a sysfs attribute is
considered a no-no.

 > +static ssize_t show_boardversion(struct device *dev,
 > +			       struct device_attribute *attr,
 > +			       char *buf)
 > +{
 > +	struct ipath_devdata *dd = dev_get_drvdata(dev);
 > +	return scnprintf(buf, PAGE_SIZE, "%s", dd->ipath_boardversion);
 > +}

Another missing "\n"