[openib-general] Re: [PATCH 8 of 20] ipath - sysfs support for core driver

[Greg KH]

On Fri, Mar 10, 2006 at 10:08:10AM -0500, Hal Rosenstock wrote:
> On Fri, 2006-03-10 at 09:59, Roland Dreier wrote:
> >     Greg> The main issue is that if you create a sysfs file like this,
> >     Greg> and then in 3 months realize that you need to change one of
> >     Greg> those characters to be something else, you are in big
> >     Greg> trouble...
> > 
> > I think that PortInfo and NodeInfo might be fair game for sysfs files,
> > because they are actually defined in the IB spec with a binary format
> > that is sent on the wire.  So they're not going to change.
> 
> Not true; There have been and likely will be more upward compatible
> changes (especially to PortInfo).

Great, that means they should NOT be exported to userspace in this
fashion...

> > On the other hand it's not clear to me why using that wire protocol as
> > an interface to userspace is a good idea...

Agreed.

thanks,

greg k-h