[openib-general] Re: [PATCH] uDAPL/uDAT autotools - Package for udat, udaplcma, udaplscm

[Bryan O'Sullivan]

Thanks, Arlin.  I think we'll use this stuff instead of Moni's patch, as
it's smaller and cleaner.

> I do have a hack regarding the disti switch (OSVENDOR="REDHAT_EL4") required for the uDAPL build. We
> need to clean this up with a real disti check. I wasn't sure how to check and set the disti
> accordingly in the Makefile.am.

Um, what's a disti?

> +%define prefix /usr

This should go.

> +Copyright: Dual GPL/BSD/CPL

This needs to be "License", and I'm pretty sure that recent versions of
rpmbuild will choke on the license string.  Please try building the
package on e.g. FC4 to see.

> +%files
> +%defattr(-,root,root)
> +%{_libdir}/libda*.so

You need to have a numbered .so file in the main package, e.g.
libdatfoo.so.1.2.  You can set this up during %install; see what I do
for other packages in the 1.0 branch.

> +%{_includedir}/dat/dat.h
> +%{_includedir}/dat/dat_error.h
> +%{_includedir}/dat/dat_platform_specific.h
> +%{_includedir}/dat/dat_redirection.h
> +%{_includedir}/dat/dat_registry.h
> +%{_includedir}/dat/dat_vendor_specific.h
> +%{_includedir}/dat/udat_config.h
> +%{_includedir}/dat/udat.h
> +%{_includedir}/dat/udat_redirection.h
> +%{_includedir}/dat/udat_vendor_specific.h

All of this stuff belongs in a separate -devel package, along with a
plain .so, which should be a symlink to the numbered .so file above.

	<b