[openib-general] Re: [PATCH] uDAPL/uDAT autotools - Package for udat, udaplcma, udaplscm

[Arlin Davis]

James Lentini wrote:

>Arlin,
>
>I like this approach better than the one Moni took. I'd rather keep 
>the original makefiles clean and add a new "package" build system.
>
>A coulpe of questions:
>
>On Wed, 15 Mar 2006, Arlin Davis wrote:
>
>  
>
>>Index: dapl/udapl/dapl_init.c
>>===================================================================
>>--- dapl/udapl/dapl_init.c	(revision 5854)
>>+++ dapl/udapl/dapl_init.c	(working copy)
>>@@ -66,8 +66,7 @@
>>  *
>>  * Return Values:
>>  */
>>-void 
>>-dapl_init ( void )
>>+static void __attribute__((constructor)) dapl_init ( void )
>> {
>>     DAT_RETURN		dat_status;
>> 
>>@@ -118,7 +117,6 @@ dapl_init ( void )
>> 
>> bail:
>>     dapl_dbg_log (DAPL_DBG_TYPE_ERR, "ERROR: dapl_init failed\n");
>>-    dapl_fini ();
>>    
>>
>
>Why is this call being removed?
>  
>
I moved away from the -init dapl_init and -fini dapl_init linker flags 
and redefined as constructor and destructor.  dapl_fini will always be 
called. Which brings up a good point. There is no guarantee that the 
init will always succeed so should we have a check in the open call and 
the fini call?

>  
>
>>     return;
>> }
>> 
>>@@ -140,8 +138,7 @@ bail:
>>  *
>>  * Return Values:
>>  */
>>-void 
>>-dapl_fini ( void )
>>+static void __attribute__((destructor)) dapl_fini ( void )
>> {
>>     DAT_RETURN		dat_status;
>> 
>>Index: dapl/udapl/libdaplscm.map
>>===================================================================
>>--- dapl/udapl/libdaplscm.map	(revision 0)
>>+++ dapl/udapl/libdaplscm.map	(revision 0)
>>@@ -0,0 +1,257 @@
>>+DAPL_CMA_1.2 {
>>    
>>
>
>Should this be "DAPL_SCM_1.2"?
>  
>
yes

>  
>
>>+        global:
>>    
>>
>
>Do any of these need to be global?
>
>  
>
ok,  I will cut down the .map files.

>  
>
>>+	local: *;
>>+};
>>Index: Makefile.am
>>===================================================================
>>--- Makefile.am	(revision 0)
>>+++ Makefile.am	(revision 0)
>>@@ -0,0 +1,342 @@
>>+# $Id: $
>>+
>>+# TODO...Need check to set properly
>>+OSVENDOR="REDHAT_EL4"
>>    
>>
>
>Does this help? A system's Red Hat release can be found in 
>/etc/redhat-release. 
>
>I'm not sure how to figure out the equivalent info for a SuSE system.
>  
>
I am looking for an autotools expert to help us here. What would a disti 
check look like in Makefile.am?

>  
>
>>+
>>+sysconf_DATA = doc/dat.conf
>>+
>>+datlibdir = $(libdir)
>>+dapllibcmadir = $(libdir)
>>+dapllibscmdir = $(libdir)
>>
>>+%description
>>+Along with the OpenIB kernel drivers, libdat and libdapl provides a userspace
>>+RDMA API that supports DAT 2.0 specification
>>    
>>
>
>This should read "1.2 specification", right?
>  
>
correct