[openib-general] [PATCH] vendor: identify rmpp mads

[Hal Rosenstock]

Hi Sean,

On Thu, 2006-03-16 at 13:05, Sean Hefty wrote:
> >> > static inline int is_rmpp_data(struct ib_mad *mad)
> >> > {
> >> >         /* check if has rmpp header */
> >> >         if (mad->mad_hdr.mgmt_class != IB_MGMT_CLASS_SUBN_ADM &&
> >> >             mad->mad_hdr.mgmt_class != IB_MCLASS_DEV_MGMT &&
> >> >             (mad->mad_hdr.mgmt_class < IB_MGMT_CLASS_VENDOR_RANGE2_START
> >> > ||
> >> >              mad->mad_hdr.mgmt_class > IB_MGMT_CLASS_VENDOR_RANGE2_END))
> >> >                 return 0;
> >>
> >> Can you explain what is wrong with the existing RMPP checks?
> >
> >I think it is that DevMgt also supports RMPP.
> 
> I can't find is_rmpp_data() in the code.  So, I'm assuming that this routine is
> a new check for something.  What are the existing checks missing?

I think this is a patch against an older version (and the class name is
IB_MGMT_CLASS_DEVICE_MGMT r.t. IB_MCLASS_DEV_MGMT as well)

user_mad.c::data_offset/ib_umad_write as well as mad_rmpp.c::data_offset
need a change for this. I will post a patch for this.

-- Hal

> - Sean
>