[openib-general] Re: [PATCH 0/7] AMSO1100 RNIC Driver
Roland Dreier
rdreier at cisco.com
Thu Mar 16 17:08:20 PST 2006
> - write[wl](0,...) benign, but arguably bogus
I think this is perfectly fine. No need to obfuscate or worry about
byte ordering for a constant 0.
> - write[wl](LE anything, ...) should be correct, yes?
Yes. For example stuff like this is OK (assuming I'm understanding it
correctly):
> + writel(0, c2dev->regs + C2_IDIS);
> + netimr0 = readl(c2dev->regs + C2_NIMR0);
> + netimr0 &= ~(C2_PCI_HTX_INT | C2_PCI_HRX_INT);
> + writel(netimr0, c2dev->regs + C2_NIMR0);
- R.
More information about the general
mailing list