[openib-general] [RFC] [PATCHv2] mad: Add RMPP support foradditional management classes which support it
Sean Hefty
mshefty at ichips.intel.com
Mon Mar 20 11:47:32 PST 2006
Hal Rosenstock wrote:
> I looked through the code and here's my take:
> If we validate ib_register_mad_agent and ib_post_send_mad so that RMPP
> is consistent with the MAD class being used, then I think what you say
> about chaing data_offset makes sense. (In the case of register agent, it
> is the management class in the registration request.) Does that make
> sense to you ? If so, I will work up a patch for this approach.
If I'm understanding correctly, this makes sense. My concern with the v2 patch
dealt with the inconsistency of how ib_get_rmpp_data_offset() was being used by
usermad.c. The two solutions that I saw to fix this was either changing
ib_get_rmpp_data_offset() to make it more generic, or changing usermad.c to call
it appropriately. I don't have a strong preference on which approach is taken.
- Sean
More information about the general
mailing list