[openib-general] Re: RFC: kill CFLAGS in makefiles?

Michael S. Tsirkin mst at mellanox.co.il
Wed Mar 22 04:02:30 PST 2006


Quoting r. Or Gerlitz <ogerlitz at voltaire.com>:
> Subject: Re: RFC: kill CFLAGS in makefiles?
> 
> Michael S. Tsirkin wrote:
> 
> >Yea, that's confusing, too.
> >We do it inside an ifdef anyway, so why not
> >#include <rdma/backport.file.h>
> >
> >and be done with it?
> 
> b/c we have
> 
> #include <some-subsystem-which-might-not-be-rdma/backport.file.h>
> 
> so its more general, we can take advantage of putting anything 
> past/future crazy below include/ at the openib svn

Things should be named properly. Anything else sounds like inviting trouble.

-- 
Michael S. Tsirkin
Staff Engineer, Mellanox Technologies



More information about the general mailing list