[openib-general] Re: RFC: kill CFLAGS in makefiles?

[Or Gerlitz]

Michael S. Tsirkin wrote:
> Quoting r. Or Gerlitz <ogerlitz at voltaire.com>:
>> Subject: Re: RFC: kill CFLAGS in makefiles?
>>
>> Michael S. Tsirkin wrote:
>>> Things should be named properly. Anything else sounds like inviting 
>>> trouble.
>> whats wrong in the naming eg of
>>
>> #include <linux/mutex-backport.h>
>> #include <linux/index.h>
>> #include <rdma/local-sa.h>


> Nothing. 

OK, for me agreeing on this point is enough to consider the issue 
closed. If others see it differently they might respond to the below.

 > But that's not what we had for mutex backport.
> We had
> 
> #if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,16)
> #include <linux/mutex-backport.h>
> #else
> #include <linux/mutex.h>
> #endif /* XXX end of hack */
> 
> and this could have just as easily been
> 
> #if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,16)
> #include <rdma/mutex-backport.h>
> #else
> #include <linux/mutex.h>
> #endif /* XXX end of hack */
> 
> since this code goes nowhere near the git tree.
>