[openib-general] Re: [PATCH] Disregard subn->min_ca_rate/mtu during MC Group creation.

[Hal Rosenstock]

On Wed, 2006-03-22 at 08:25, Sasha Khapyorsky wrote:
> Hello,
> 
> Now at MC Group creation when exact rate or MTU values are requested and
> those values are greater than rate (or mtu) of slowest port on the subnet
> then MC group creation fails. It is likely not desired behaviour.

Yes, if there were such a check it would be against max_ca_mtu/rate and
even that is subject to change post group creation as the subnet changes
so this doesn't seem like a good idea to me (to be checking it here).

-- Hal

> Sasha.
> 
> 
> Disregard subn->ca_min_mtu and subn->ca_min_rate when new MC group is
> created and exact MTU and/or rate values are specified.
> 
> 
> Signed-off-by: Sasha Khapyorsky <sashak at voltaire.com>
> ---
> 
>  osm/opensm/osm_sa_mcmember_record.c |   12 ++++++------
>  1 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/osm/opensm/osm_sa_mcmember_record.c b/osm/opensm/osm_sa_mcmember_record.c
> index ce1d036..826c4d3 100644
> --- a/osm/opensm/osm_sa_mcmember_record.c
> +++ b/osm/opensm/osm_sa_mcmember_record.c
> @@ -1121,12 +1121,12 @@ __mgrp_request_is_realizable(
>        break;
>      case 2: /* Exactly MTU specified */
>        /* make sure it is in the range */
> -      if ((1 > mtu_required) || (mtu_required > p_rcv->p_subn->min_ca_mtu))
> +      if ((1 > mtu_required))
>        {
>          osm_log( p_log, OSM_LOG_DEBUG,
>                   "__mgrp_request_is_realizable: "
> -                 "Requested MTU %x out of range: 1 .. %x\n",
> -                 mtu_required, p_rcv->p_subn->min_ca_mtu);
> +                 "Requested MTU %x is less than 1\n",
> +                 mtu_required);
>          return FALSE;
>        }
>        break;
> @@ -1198,12 +1198,12 @@ __mgrp_request_is_realizable(
>        break;
>      case 2: /* Exactly RATE specified */
>        /* make sure it is in the range */
> -      if ((2 > rate_required) || (rate_required > p_rcv->p_subn->min_ca_rate))
> +      if ((2 > rate_required))
>        {
>          osm_log( p_log, OSM_LOG_DEBUG,
>                   "__mgrp_request_is_realizable: "
> -                 "Requested RATE %x out of range: 2 .. %x\n",
> -                 rate_required, p_rcv->p_subn->min_ca_rate);
> +                 "Requested RATE %x is less than 2\n",
> +                 rate_required);
>          return FALSE;
>        }
>        break;