[openib-general] Re: [PATCH 8 of 18] ipath - sysfs and ipathfs support for core driver

[Bryan O'Sullivan]

On Wed, 2006-03-22 at 21:49 -0800, Greg KH wrote:

> Why are you testing kobj.dentry in these functions?

I think this is a holdover from an earlier version of the driver that
didn't clean up properly after driver registration failed.  In other
words, those tests are no longer needed.  Thanks for spotting this.

> Oh, and I like your new filesystem, but where do you propose that it be
> mounted?

I don't have any good candidates in mind.  In our development
environment, we're mounting it in /ipath, but that doesn't seem like a
good long-term name.  Do you have any suggestions?

> You leak a group if the second call to sysfs_create_group() fails for
> some reason.

Thanks.

	<b