[openib-general] Re: [PATCH] IPoIB network interface "RUNNING" statuswith the cable disconnected - fix

Michael S. Tsirkin mst at mellanox.co.il
Thu Mar 23 05:27:53 PST 2006


Quoting r. Leonid Arsh <leonida at voltaire.com>:
> >Also, for the future, is there some way we can be smarter about link
> >down events?  There's no sense in starting to try and join multicast
> >groups, etc. if we know that the port is down.

...

> As to the event handling, you are right.
> I think we should review the event handling design in IPoIB and change
> it a bit, to make it smarter.

I guess we could add another task for this purpose, running out of
ipoib_workqueue.  But I'm not sure its worth it - no actual harm is done,
and it sure is easy to intruduce subtle races here, quite hard to debug.

-- 
Michael S. Tsirkin
Staff Engineer, Mellanox Technologies



More information about the general mailing list