[openib-general] Re: [PATCH] Disregard subn->min_ca_rate/mtu during MCGroupcreation.

[Hal Rosenstock]

On Thu, 2006-03-23 at 11:22, Sasha Khapyorsky wrote:
> On 10:24 Thu 23 Mar     , Hal Rosenstock wrote:
> > 
> > On Thu, 2006-03-23 at 09:57, Eitan Zahavi wrote:
> > > Now I get it. Its my bug.
> > > What I meant was to check that the request is realizable:
> > > if ((2 > rate_required) || (rate_required > p_rcv->p_subn->min_ca_rate))
> > > Should catch the case where the rate required is too slow to be valid or
> > > if it is faster then the MAX rate of the fabric. But the use of
> > > min_ca_rate is incorrect it should be a new variable (probably named:
> > > max_ca_rate) that would hold the MAX rate of all the CA ports...
> > 
> > Yes, that's what I said in a separate email. 
> > 
> > if ((2 > rate_required) || (rate_required > p_rcv->p_subn->max_ca_rate))
> > makes sense
> > 
> > But is that field set to the max rate/MTU ? (I didn't check the code for
> > this). Is it just a name thing or more ?
> 
> This is more then just name. Currently we only have min_ca_rate which
> stores value of slowest port's rate. What we will need is similar
> variable for fastest port's rate, and then to check against it. I like
> this idea and this should be easy enouph to  do.

As the max rate/MTU port on the subnet can change, is this worth it ?
The realizability is when the port joins not when the group is created.
This is significant for the precreated groups (as other groups are
created when the first port joins).

Is min rate/MTU needed for anything ?

-- Hal