[openib-general] Re: [PATCH] for 2.6.17: mad: include GID/class when matching receives

[Sean Hefty]

Roland Dreier wrote:
>  > Adds GID and class checking to mad receive processing when locating sent MADs.
> 
> I put this in my tree.  But is there a better changelog available?
> Like, why do we want to add that checking?  And the subject line says
> "matching receives" but the body says "locating sent MADs", which is
> kind of confusing.

I just pulled the changelog from the original check-in.  The code is trying to 
fix an issue matching a received MAD with the correct send request, if that 
helps with the confusion any.  How about adding this to the change log:

Received responses are currently matched against sent requests based on TID 
only.  According to the spec, responses should match based on the combination of 
TID, management class, and requester LID/GID.

Without the additional qualification, an agent that is responding to two 
requests, both of which have the same TID, can match RMPP ACKs with the 
incorrect transaction.  This problem can occur on the SM node when responding to 
SA queries.

- Sean