[openib-general] [PATCH] krping : Erroneous return on wake-up from function krping_bind_client

Pradipta Kumar Banerjee bpradip at in.ibm.com
Fri Mar 31 08:32:53 PST 2006


* Steve Wise <swise at opengridcomputing.com> [060331 21:50]:
> Hello Pradipta,
> 
> I think this is already fixed in the latest krping revision (committed
> under r5907).

Hi Steve,
 The one which I downloaded today (revision 6131) didn't contained the
fix :-) , hence sent it.

--
Thanks
Pradipta Kumar.

> 
> Thanks!
> 
> Steve.
> 
> 
> On Fri, 2006-03-31 at 21:30 +0530, Pradipta Kumar Banerjee wrote:
> > Hi
> > 
> > The present code returns success after waking up even for the case when 
> > cb->state is not equal to ROUTE_RESOLVED.
> > 
> > Signed-off-by: Pradipta Kumar B <bpradip at in.ibm.com>
> > 
> > ---
> > 
> > Index: krping.c
> > =====================================================================
> > --- krping.org	2006-03-31 12:53:28.000000000 +0530
> > +++ krping.c	2006-03-31 17:16:00.000000000 +0530
> > @@ -887,7 +887,7 @@ static int krping_bind_client(struct krp
> >  		printk(KERN_ERR PFX 
> >  		       "waiting for addr/route resolution state %d\n",
> >  		       cb->state);
> > -		return ret;
> > +		return -1;
> >  	}
> >  
> >  	DEBUG_LOG("rdma_resolve_addr - rdma_resolve_route successful\n");
> > _______________________________________________
> > openib-general mailing list
> > openib-general at openib.org
> > http://openib.org/mailman/listinfo/openib-general
> > 
> > To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
> 




More information about the general mailing list