[openib-general] [PATCH] SRP: Avoid a potential deadlock

Ishai Rabinovitz ishai at mellanox.co.il
Mon May 1 04:35:48 PDT 2006


Hi,

I think there is a potential deadlock when disconnecting from the CM.
Roland, can you look at this patch and check if it is needed.

Thanks
Ishai

----------------------------------------------------------------------

Avoid a potential dead-lock.
In srp_disconnect_target there is a call to ib_send_cm_dreq 
and a wait for completion 
If when getting DREP there is no comp no one will end this wait

Signed-off-by: Ishai Rabinovitz <ishai at mellanox.co.il>

Index: last_stable/drivers/infiniband/ulp/srp/ib_srp.c
===================================================================
--- last_stable.orig/drivers/infiniband/ulp/srp/ib_srp.c	2006-04-17 10:03:08.000000000 +0300
+++ last_stable/drivers/infiniband/ulp/srp/ib_srp.c	2006-04-17 10:06:19.000000000 +0300
@@ -1194,6 +1194,7 @@ static int srp_cm_handler(struct ib_cm_i
 		break;
 
 	case IB_CM_DREP_RECEIVED:
+		comp = 1;
 		break;
 
 	case IB_CM_TIMEWAIT_EXIT:
-- 
Ishai Rabinovitz



More information about the general mailing list