[openib-general] Re: [PATCH 5 of 13] ipath - use proper address translation routine

Bryan O'Sullivan bos at pathscale.com
Mon May 1 12:03:16 PDT 2006


On Mon, 2006-05-01 at 11:50 -0700, Roland Dreier wrote:
>     Bryan> Move away from an obsolete, unportable routine for
>     Bryan> translating physical addresses.
> 
> This change:
> 
>  > -		isge->vaddr = bus_to_virt(sge->addr);
>  > +		isge->vaddr = phys_to_virt(sge->addr);
> 
> is really wrong.  bus_to_virt() is really what you want, because in
> this case the address is a bus address that came from dma_map_xxx().

Well, bus_to_virt is not portable, so we definitely can't use it.  I'll
have to do some thinking about this.

	<b




More information about the general mailing list