[openib-general] [PATCH] osm_vendor_mlx.c : missing pointer check

Ofer Gigi oferg at mellanox.co.il
Mon May 8 00:05:49 PDT 2006


Hi Hal,

Bug fix:
When the driver is down and you try to raise opensm - it exits in
segmentation
fault. The reason for this is that __osm_vendor_internal_unbind is
called
with h_bind==0.

Thanks

Ofer G.

Signed-off-by:  Ofer Gigi <oferg at mellanox.co.il>

Index: osm_vendor_mlx.c
===================================================================
--- osm_vendor_mlx.c	(revision 6640)
+++ osm_vendor_mlx.c	(working copy)
@@ -357,7 +357,10 @@ osm_vendor_unbind(IN  osm_bind_handle_t 
   cl_qlist_remove_item(p_bh_list,p_item);
   if (p_obj) cl_free(p_obj);
 
+  if (h_bind != 0)
+  {
   __osm_vendor_internal_unbind(h_bind);
+  }
 
   OSM_LOG_EXIT(p_log);
 }




More information about the general mailing list