[openib-general][PATCH] srp: tuned parameters,

[Roland Dreier]

I finally looked this over.

First, this should be two patches: making srp_sg_tablesize tunable
should be a separate change from making it possible to specify
max_cmd_per_lun for a target.

The srp_sg_tablesize change makes the default number of SG entries
quite a bit larger than it is now, which makes the default max IU
length much bigger.  Is this justified?  What workload creates such
huge SG lists?

For the cmd_per_lun change, shouldn't the line

> +			target->scsi_host->cmd_per_lun = token;

be something like

			target->scsi_host->cmd_per_lun = min(token, SRP_SQ_SIZE);

otherwise it's too easy to overflow a send queue by mistake.

 - R.