[openib-general] [PATCH v3] ipoib: convert to use new multicast interface
Michael S. Tsirkin
mst at mellanox.co.il
Thu May 11 13:04:17 PDT 2006
Quoting r. Sean Hefty <mshefty at ichips.intel.com>:
> Subject: Re: [openib-general] [PATCH v3] ipoib: convert to use new multicast interface
>
> Michael S. Tsirkin wrote:
> >I'm nervous about doing big changes in the multicast code in ipoib - it had
> >more than a fair share of subtle races.
>
> The patch simplifies the multicast code in ipoib, and the serialization in
> the multicast module is simple enough that we should be able to have a fair
> amount of confidence that races are avoided. (It's not like I'm biased or
> anything.) The code just needs more testing.
I'm not against this approach on principle, I hope I didn't make it sound like I
am. I just don't feel IPoIB should be the first user of *any* module.
> Going forward, it makes more sense to have ipoib use the multicast module.
> The only question to me is when that conversion takes place. I'm also
> worried about having to try to regenerate the patch after other changes go
> into the code.
I don't think anyone's touching ipoib_multicast.c at the moment, so don't worry
about that.
--
MST
More information about the general
mailing list