[openib-general] Re: [PATCH 41 of 53] ipath - disable interrupts while holding spinlock in RWQE get
Roland Dreier
rdreier at cisco.com
Mon May 15 08:55:37 PDT 2006
> @@ -171,12 +171,13 @@ int ipath_get_rwqe(struct ipath_qp *qp,
> n = rq->head - rq->tail;
> if (n < srq->limit) {
> srq->limit = 0;
> - spin_unlock(&rq->lock);
> + spin_unlock_irqrestore(&rq->lock, flags);
> ev.device = qp->ibqp.device;
> ev.element.srq = qp->ibqp.srq;
> ev.event = IB_EVENT_SRQ_LIMIT_REACHED;
> srq->ibsrq.event_handler(&ev,
> srq->ibsrq.srq_context);
> + spin_lock_irqsave(&rq->lock, flags);
ipath_get_rwqe() in the kernel now doesn't even have a flags
variable. So this looks like a bug introduced earlier in this patch
series. Please roll the fix up into the place where you added the bug.
- R.
More information about the general
mailing list