[openib-general][PATCH] srp: param sg_tablesize,

Vu Pham vuhuong at mellanox.com
Wed May 17 17:04:42 PDT 2006



> @@ -1914,6 +1920,11 @@ static int __init srp_init_module(void)
>  {
>  	int ret;
>  


Thanks, should we do a check and put some cap on 
srp_sg_tablesize value ie.

+	srp_sg_tablesize = max(1, srp_sg_tablesize);
+	srp_sg_tablesize = min(srp_sg_tablesize, 
SRP_MAX_SG_TABLESIZE);

> +	srp_template.sg_tablesize = srp_sg_tablesize;
> +	srp_max_iu_len = (sizeof (struct srp_cmd) +
> +			  sizeof (struct srp_indirect_buf) +
> +			  srp_sg_tablesize * 16);
> +

>  
>  	SRP_MAX_LUN		= 512,
> -	SRP_MAX_IU_LEN		= 256,
> +	SRP_DEF_SG_TABLESIZE	= 12,

+	SRP_MAX_SG_TABLESIZE	= 128,




More information about the general mailing list