[openib-general] [PATCH] comma at end of enumerator list

Michael S. Tsirkin mst at mellanox.co.il
Mon May 22 08:31:01 PDT 2006


While comma at end of enumerator list is legal since 1999, some
tools (notably gcc versions pre-4.0) seem to default to 1989 mode when running
with -pedantic flag, and warn about this usage.

Since most of our enums in header files do not have comma at end, its probably
easier to fix the remaining two cases than educate all users of libibverbs on
virtues of C99.

Signed-off-by: Michael S. Tsirkin <mst at mellanox.co.il>

Index: libibverbs/include/infiniband/verbs.h
===================================================================
--- libibverbs/include/infiniband/verbs.h	(revision 7212)
+++ libibverbs/include/infiniband/verbs.h	(working copy)
@@ -88,7 +88,7 @@
 	IBV_DEVICE_SYS_IMAGE_GUID	= 1 << 11,
 	IBV_DEVICE_RC_RNR_NAK_GEN	= 1 << 12,
 	IBV_DEVICE_SRQ_RESIZE		= 1 << 13,
-	IBV_DEVICE_N_NOTIFY_CQ		= 1 << 14,
+	IBV_DEVICE_N_NOTIFY_CQ		= 1 << 14
 };
 
 enum ibv_atomic_cap {
@@ -338,7 +338,7 @@
 
 enum ibv_srq_attr_mask {
 	IBV_SRQ_MAX_WR	= 1 << 0,
-	IBV_SRQ_LIMIT	= 1 << 1,
+	IBV_SRQ_LIMIT	= 1 << 1
 };
 
 struct ibv_srq_attr {

-- 
MST



More information about the general mailing list