[openib-general] [PATCH][1/7]ipoib performance patches -- split CQ

Roland Dreier rdreier at cisco.com
Tue May 23 09:09:05 PDT 2006


Did you send the other 6 patches in this series?

I was waiting to comment until I had all the patches, but there is one
really bad thing here:

 > +       IPOIB_NUM_SEND_WC         = 32,

 > +void ipoib_ib_send_completion(struct ib_cq *cq, void *dev_ptr)
 > +{
 > +       struct net_device *dev = (struct net_device *) dev_ptr;
 > +       struct ipoib_dev_priv *priv = netdev_priv(dev);
 > +       struct ib_wc ibwc[IPOIB_NUM_SEND_WC];

If I'm doing the math correctly, this function now uses more than 2K
of stack, which is of course unacceptable.

I don't think there's any way around keeping the wc array in the
ipoib_dev_priv structure.

 - R.



More information about the general mailing list