[openib-general] [PATCH 2.6.19 1/4] ehca: assure 4k alignment for firmware control block in 64k page mode

Hoang-Nam Nguyen HNGUYEN at de.ibm.com
Mon Nov 6 02:00:00 PST 2006


Hi Arnd,
> This seems broken. You have a constructor for newly allocated objects,
but
> there is no destructor and it seems that objects passed to
> ehca_free_fw_ctrlblock are not guaranteed to be initialized either.
> I'd simply move the memset into the alloc function and get rid of the
> constructor here.
Yep, I was not aware that ctor is not called for every
kmem_cache_alloc(). Thx for pointing this out.
Nam





More information about the general mailing list