[openib-general] [Fwd: [PATCH] RDMA/iwcm: Rewrite comment for iwcm_deref_id() to match code.]

[Steve WIse]

Roland,

Comment cleanup for 2.6.20.

Acked-by: Steve Wise <swise at opengridcomputing.com>

-------- Forwarded Message --------
From: Krishna Kumar <krkumar2 at in.ibm.com>
To: openib-general at openib.org
Subject: [openib-general] [PATCH] RDMA/iwcm: Rewrite comment for
iwcm_deref_id() to match code.
Date: Thu, 09 Nov 2006 09:30:48 +0530

In iwcm_deref_id(), the comment says : "If the last
reference is being removed and iw_destroy_cm_id is
waiting, wake up the waiting thread". The second part
of the comment "and iw_destroy_cm_id is waiting" is
wrong, since this function either wakes the waiter
already waiting in iwcm_deref_id, or enables it (so
that when wait_for_completion() is performed later,
it will immediately return).

Signed-off-by: Krishna Kumar <krkumar2 at in.ibm.com>
---
diff -ruNp org/drivers/infiniband/core/iwcm.c new/drivers/infiniband/core/iwcm.c
--- org/drivers/infiniband/core/iwcm.c	2006-10-09 16:40:04.000000000 +0530
+++ new/drivers/infiniband/core/iwcm.c	2006-10-09 16:52:03.000000000 +0530
@@ -148,8 +148,9 @@ static int copy_private_data(struct iw_c
 }
 
 /*
- * Release a reference on cm_id. If the last reference is being removed
- * and iw_destroy_cm_id is waiting, wake up the waiting thread.
+ * Release a reference on cm_id. If the last reference is being
+ * released, enable the waiting thread (in iw_destroy_cm_id) to
+ * get woken up, and return 1 if a thread is already waiting.
  */
 static int iwcm_deref_id(struct iwcm_id_private *cm_id_priv)
 {

_______________________________________________
openib-general mailing list
openib-general at openib.org
http://openib.org/mailman/listinfo/openib-general

To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general