[openib-general] IB/ipath - Implement new verbs DMA mapping functions

Muli Ben-Yehuda muli at il.ibm.com
Sun Nov 12 01:59:16 PST 2006


On Thu, Nov 02, 2006 at 02:30:26PM -0800, Ralph Campbell wrote:

> +static dma_addr_t ipath_dma_map_single(struct ib_device *dev,
> +				       void *cpu_addr, size_t size,
> +				       enum dma_data_direction direction)
> +{
> +	BUG_ON(direction == DMA_NONE);

Please use BUG_ON(!valid_dma_direction(direction)) here and elsewhere
instead.

Cheers,
Muli




More information about the general mailing list