[openib-general] [PATCH] OpenSM: Change default to be no QoS

Hal Rosenstock halr at voltaire.com
Wed Nov 22 12:43:00 PST 2006


OpenSM: Change default to be no QoS
QoS must be explictly enabled

Signed-off-by: Hal Rosenstock <halr at voltaire.com>

Index: opensm/main.c
===================================================================
--- opensm/main.c	(revision 10154)
+++ opensm/main.c	(working copy)
@@ -247,8 +247,8 @@ show_usage(void)
           "          This option defines the optional partition configuration file.\n"
 	  "          The default name is \'" OSM_DEFAULT_PARTITION_CONFIG_FILE "\'.\n\n");
   printf( "-Q\n"
-          "--no_qos\n"
-          "          This option disables QoS setup.\n\n");
+          "--qos\n"
+          "          This option enables QoS setup.\n\n");
   printf( "-N\n"
           "--no_part_enforce\n"
           "          This option disables partition enforcement on switch external ports.\n\n");
@@ -561,7 +561,7 @@ main(
       {  "erase_log_file",0, NULL, 'e'},
       {  "Pconfig",       1, NULL, 'P'},
       {  "no_part_enforce",0,NULL, 'N'},
-      {  "no_qos",        0, NULL, 'Q'},
+      {  "qos",           0, NULL, 'Q'},
       {  "maxsmps",       1, NULL, 'n'},
       {  "console",       0, NULL, 'q'},
       {  "V",             0, NULL, 'V'},
@@ -762,7 +762,7 @@ main(
       break;
 
     case 'Q':
-      opt.no_qos = TRUE;
+      opt.no_qos = FALSE;
       break;
 
     case 'y':
Index: opensm/osm_subnet.c
===================================================================
--- opensm/osm_subnet.c	(revision 10154)
+++ opensm/osm_subnet.c	(working copy)
@@ -482,7 +482,7 @@ osm_subn_set_default_opt(
   p_opt->log_max_size = 0;
   p_opt->partition_config_file = OSM_DEFAULT_PARTITION_CONFIG_FILE;
   p_opt->no_partition_enforcement = FALSE;
-  p_opt->no_qos = FALSE;
+  p_opt->no_qos = TRUE;
   p_opt->accum_log_file = TRUE;
   p_opt->port_profile_switch_nodes = FALSE;
   p_opt->pfn_ui_pre_lid_assign = NULL;
Index: man/opensm.8
===================================================================
--- man/opensm.8	(revision 10154)
+++ man/opensm.8	(working copy)
@@ -1,11 +1,11 @@
-.TH OPENSM 8 "October 30, 2006" "OpenIB" "OpenIB Management"
+.TH OPENSM 8 "November 22, 2006" "OpenIB" "OpenIB Management"
 
 .SH NAME
 opensm \- InfiniBand subnet manager and administration (SM/SA) 
 
 .SH SYNOPSIS
 .B opensm
-[\-c(ache-options)] [\-g(uid)[=]<GUID in hex>] [\-l(mc) <LMC>] [\-p(riority) <PRIORITY>] [\-smkey <SM_Key>] [\-r(eassign_lids)] [\-R <engine name> | \-routing_engine <engine name>] [\-M <file name> | \-lid_matrix_file <file name>] [\-U <file name> | \-ucast_file <file name>] [\-a(dd_guid_file) <path to file>] [\-o(nce)] [\-s(weep) <interval>] [\-t(imeout) <milliseconds>] [\-maxsmps <number>] [\-console] [\-i(gnore-guids) <equalize-ignore-guids-file>] [\-f | \-\-log_file] [\-L | \-\-log_limit <size in MB>] [\-e(rase_log_file)] [\-P(config)] [\-Q | \-no_qos] [\-N | \-no_part_enforce] [\-y | \-stay_on_fatal] [\-v(erbose)] [\-V] [\-D <flags>] [\-d(ebug) <number>] [\-h(elp)] [\-?]
+[\-c(ache-options)] [\-g(uid)[=]<GUID in hex>] [\-l(mc) <LMC>] [\-p(riority) <PRIORITY>] [\-smkey <SM_Key>] [\-r(eassign_lids)] [\-R <engine name> | \-routing_engine <engine name>] [\-M <file name> | \-lid_matrix_file <file name>] [\-U <file name> | \-ucast_file <file name>] [\-a(dd_guid_file) <path to file>] [\-o(nce)] [\-s(weep) <interval>] [\-t(imeout) <milliseconds>] [\-maxsmps <number>] [\-console] [\-i(gnore-guids) <equalize-ignore-guids-file>] [\-f | \-\-log_file] [\-L | \-\-log_limit <size in MB>] [\-e(rase_log_file)] [\-P(config)] [\-Q | \-qos] [\-N | \-no_part_enforce] [\-y | \-stay_on_fatal] [\-v(erbose)] [\-V] [\-D <flags>] [\-d(ebug) <number>] [\-h(elp)] [\-?]
 
 .SH DESCRIPTION
 .PP
@@ -156,8 +156,8 @@ is accumulative.
 This option defines the optional partition configuration file.
 The default name is \'/etc/osm-partitions.conf\'.
 .TP
-\fB\-Q\fR, \fB\-\-no_qos\fR
-This option disables QoS setup. It is enabled by default.
+\fB\-Q\fR, \fB\-\-qos\fR
+This option enables QoS setup. It is disabled by default.
 .TP
 \fB\-N\fR, \fB\-\-no_part_enforce\fR
 This option disables partition enforcement on switch external ports.







More information about the general mailing list