[openib-general] [PATCH] Avoid truncating to 'long' in ALIGN() macro
David Miller
davem at davemloft.net
Sat Nov 25 15:05:00 PST 2006
From: Roland Dreier <rdreier at cisco.com>
Date: Sat, 25 Nov 2006 14:56:22 -0800
> > Perhaps a better way to fix this is to use
> > typeof() like other similar macros do.
>
> I tried doing
>
> #define ALIGN(x,a) \
> ({ \
> typeof(x) _a = (a); \
> ((x) + _a - 1) & ~(_a - 1); \
> })
>
> but that won't compile because of <net/neighbour.h>:
You would need to also cast the constants with typeof() to.
But yes, given the array sizing case in the neighbour code,
perhaps we can use your original patch for now. Feel free
to push that to Linus.
More information about the general
mailing list