[openib-general] [PATCH] Avoid truncating to 'long' in ALIGN() macro
Al Viro
viro at ftp.linux.org.uk
Sat Nov 25 17:10:14 PST 2006
On Sat, Nov 25, 2006 at 03:05:00PM -0800, David Miller wrote:
> From: Roland Dreier <rdreier at cisco.com>
> Date: Sat, 25 Nov 2006 14:56:22 -0800
>
> > > Perhaps a better way to fix this is to use
> > > typeof() like other similar macros do.
> >
> > I tried doing
> >
> > #define ALIGN(x,a) \
> > ({ \
> > typeof(x) _a = (a); \
> > ((x) + _a - 1) & ~(_a - 1); \
> > })
> >
> > but that won't compile because of <net/neighbour.h>:
>
> You would need to also cast the constants with typeof() to.
Oh, for fsck sake...
(typeof(x))((x + a - 1) & ~(a - 1ULL))
More information about the general
mailing list