[openib-general] [PATCH] osm: 'chmod' on Windows

Michael S. Tsirkin mst at mellanox.co.il
Sun Nov 26 23:38:27 PST 2006


> > BTW, I can count 19 another occurrences of '#ifdef WIN32' and
> > '#ifdef __WIN__' under management/osm tree. I guess that not each one
> > can be so trivially cleaned up as in this case, but would it be
> > possible to review it and reduce number of such #ifdef(s) in common
> > code?
>  
> Good idea.
> Thanks.

And in fact, most portability hacks in include/complib can be done this way if
you want to do that: e.g. cl_ntoh32 can be converted to htonl, and you can have
htonl defined in a windows-specific header.

-- 
MST




More information about the general mailing list