[openib-general] [PATCH repost] IB/ipoib: fix skb leak

[Michael S. Tsirkin]

> Quoting r. Roland Dreier <rdreier at cisco.com>:
> Subject: Re: [PATCH repost] IB/ipoib: fix skb leak
> 
> err...
> 
>  > +void ipoib_neigh_free(struct net_dev *dev, struct ipoib_neigh *neigh);
> 
> has this patch been tested much, given that it doesn't compile (hint:
> struct net_dev doesn't exist)?
> 
> @@ -787,7 +781,7 @@ static void ipoib_neigh_destructor(struc
>  		if (neigh->ah)
>  			ah = neigh->ah;
>  		list_del(&neigh->list);
> -		ipoib_neigh_free(neigh);
> +		ipoib_neigh_free(dev, neigh);
> 
> and also there is no variable dev in this scope...

Sigh. My bad. Not sure now what happened here. And I could have sworn I had this
put in our nightly regression tree, but now I actually check it's not there.
Sorry about that.

> Anyway I fixed this up for now and I'll merge it for 2.6.20-early,
> since we should have time to fix any regressions.

That should be fine - this comes from code review, not something I saw
in practice.

-- 
MST