[openib-general] [PATCH 2/10] Driver netpath files - abstraction of connection to VEx

[Roland Dreier]

 > +	if (netpath->timer_state == NETPATH_TS_ACTIVE) {
 > +		del_timer_sync(&netpath->timer);
 > +	}

kernel style is just to do

	if (netpath->timer_state == NETPATH_TS_ACTIVE)
		del_timer_sync(&netpath->timer);

this could be fixed many places.

 > +void netpath_connected(struct netpath *netpath, struct viport *viport)
 > +{
 > +	vnic_connected(netpath->parent, netpath);
 > +	return;
 > +}
 > +
 > +void netpath_disconnected(struct netpath *netpath, struct viport *viport)
 > +{
 > +	vnic_disconnected(netpath->parent, netpath);
 > +	return;
 > +}

what do the return; statement accomplish here?  In fact what do these
wrappers accomplish?

 - R.