[openib-general] [PATCH 3/10] Driver viport files - implementation of communication protocol with VEx
Roland Dreier
rdreier at cisco.com
Mon Oct 2 13:50:19 PDT 2006
Bryan> This looks like a cut-and-paste of the main driver file,
Bryan> and has the same big problem of a single huge state machine
Bryan> function and a bunch of tiny trivial stubs that all serve
Bryan> to obfuscate the code.
Yes, in general it seems like this all could be made quite a bit
smaller and easier to understand by removing some of the extraneous
layering -- almost all the functions look like trivial pass-throughs
to lower layers.
- R.
More information about the general
mailing list