[openib-general] [PATCH 5/10] Implementation of Data path of the communication protocol

Bryan O'Sullivan bos at pathscale.com
Mon Oct 2 13:59:53 PDT 2006


Ramachandra K wrote:
> Adds the files that implement the data transfer part of the
> communication protocol with the VEx. The RDMA of ethernet
> packets is implemented in here.

I see no sparse annotations to indicate endianness or user visibility of 
any data throughout the driver.  The driver should pass make C=1 
CF=-D__CHECK_ENDIAN__ cleanly, which it looks like it won't right now.

Also, I see a number of non-standard macros like ntoh16 and so on. 
Please use the normal cpu_to_be16 etc instead.

	<b




More information about the general mailing list