[openib-general] [PATCH 7/13] osm: port to WinIB stack : opensm/osm_ucast_file.c

Hal Rosenstock halr at voltaire.com
Tue Oct 3 14:45:08 PDT 2006


Hi Eitan,

On Sun, 2006-09-17 at 11:59, Eitan Zahavi wrote:
> Hi Hal
> 
> 1. Avoid varargs macros not supported by win

What about using __VA_ARGS__? It is C99, and MS claims that they
support this (http://msdn2.microsoft.com/en-us/library/ms177415.aspx),
in this way:

#define MACRO(s, ...) printf(s, __VA_ARGS__)

This should work with GNU as well.

> 2. Some explicit casting required
> 3. Use stroull and not stroll

Items 2 and 3 were applied.

-- Hal

> 
> Thanks
> 
> Eitan






More information about the general mailing list