[openib-general] [PATCH] IB_CM: Limit the MRA timeout

[Michael S. Tsirkin]

Quoting r. Sean Hefty <mshefty at ichips.intel.com>:
> Subject: Re: [PATCH] IB_CM: Limit the MRA timeout
> 
> Ishai Rabinovitz wrote:
> > There is a bug in SRP Engenio target that send a large value as service 
> > timeout. (It gets 30 which mean timeout of (2^(30-8))=4195 sec.) Such a long
> > timeout is not reasonable and it may leave the kernel module waiting on
> > wait_for_completion and may stuck a lot of processes.
> > 
> > The following patch allows the load of ib_cm module with a limit on the
> > timeout.
> 
> There's several timeout values transfered and used by the cm, most notably the 
> remote cm response timeout and packet life time.  Does it make more sense to 
> have a single, generic timeout maximum instead?

Hmm. I'm not sure - we are working around an actual broken implementation here -
what do you think?

> Would it make more sense to 
> enable the maximum(s) by default, since we're dependent upon values received 
> over the network?

I think it would.

-- 
MST