[openib-general] [PATCH] osm: port to WinIB stack

[Eitan Zahavi]

Michael S. Tsirkin wrote:

>Quoting r. Eitan Zahavi <eitan at mellanox.co.il>:
>  
>
>>The answer is that the DDK used for compiling opensm on WinIB is 
>>particularly aggressive on casting issues like this and fails the 
>>compilation.
>>    
>>
>
>AFAIK, DDK CL.EXE has a flag to give agressive warnings on potential "64
>bit portability issues".
>
>http://msdn2.microsoft.com/en-us/library/yt4xw8fh.aspx
>
>	/Wp64 - Detects 64-bit portability problems
>	/Wp64 is off by default in the Visual C++ 32-bit compiler and on by
>	default in the Visual C++ 64-bit compiler.
>	If you regularly compile your application with a 64-bit compiler, you
>	may want to disable /Wp64 in your 32-bit compilations, as the 64-bit
>	compiler will detect all issues.
>  
>
This makes sense. As we do compile for both platforms we can turn it off.

>CL.EXE seems to classify any conversion between types of different size as
>a potential "64 bit portability issue".
>I think that you also compiling with a flag which turns these warnings
>into errors:
>
>http://msdn2.microsoft.com/en-us/library/thxezb7y.aspx
>	/WX Treats all compiler warnings as errors. For a new project, it may be
>	    best to use /WX in all compilations
>
>This flag is off by default.
>It might be easier for you, in the future, to just turn it off than waste time
>fixing the warnings.
>  
>
I will probably keep this on to catch other issues.