[openib-general] FW: [PATCH fixed] [RFC] IB/srp: enable multiple connections to the same target

[Michael S. Tsirkin]

Quoting r. Lakshmanan, Madhu <mlakshmanan at silverstorm.com>:
> Subject: FW: [PATCH fixed] [RFC] IB/srp: enable multiple connections to the same target
> 
> Quoting r. Roland Dreier <rdreier at cisco.com>:
> > Thanks, queued for 2.6.19
> 
> I tested the patches, which are included in OFED 1.1 RC7, against
> Silverstorm SRP targets. The patch breaks backward compatibility for
> fabrics that use Silverstorm targets, due to the following:
> 
> It defaults the new parameter "initiator_ext" to 0. Silverstorm SRP
> targets, when configured for working with OFED stacks, are usually set
> to expect an initiator extension of 1, to overcome the earlier
> limitation of OFED stacks setting initiator extension to the port
> number.

Sounds like a target bug - why does it expect *anything* specific
in the initiator extension?

> This implies that a user must, without exception, add
> "initiator_ext=<n>" to the add target echo string.
> 
> It'd be useful if either or both of the following could be done:
> 
> 1. Release note the above requirement of adding the "initiator_ext=<n>"
> string to the add target echo string, for all Silverstorm targets.

I don't think we'll be touching OFED 1.1 anymore. So maybe this is
the best choice for kernel.org, too.

> 2. Maintain the earlier default of the initiator extension being equal
> to the port number. 
> 
> I have prepared a patch that does step 2 above, which I'll send in a
> separate e-mail based on the feedback to the above suggestions.

Hmm. What, exactly, is the target assumption?

-- 
MST