[openib-general] [PATCH]OpenSM/libvendor/osm_vendor_ibumad.c: Print errors to stderr rather than stdout

Eitan Zahavi eitan at mellanox.co.il
Mon Oct 9 11:37:47 PDT 2006


Hi Hal,

I would rather remove all of these. At least for the non debug build.
I do not see how they help the user .

What do you say?

EZ
Hal Rosenstock wrote:

>OpenSM/libvendor/osm_vendor_ibumad.c: Print errors to stderr rather than
>stdout
>
>Signed-off-by: Hal Rosenstock <halr at voltaire.com>
>
>Index: libvendor/osm_vendor_ibumad.c
>===================================================================
>--- libvendor/osm_vendor_ibumad.c	(revision 9751)
>+++ libvendor/osm_vendor_ibumad.c	(working copy)
>@@ -745,8 +745,8 @@ osm_vendor_open_port(
> 				"osm_vendor_open_port: ERR 542D: "
> 				"Node type %d is not an IB node type\n",
> 				p_vend->umad_ca.node_type );
>-		printf( "\nNode type %d is not an IB node type\n",
>-			p_vend->umad_ca.node_type );
>+		fprintf( stderr, "\nNode type %d is not an IB node type\n",
>+			 p_vend->umad_ca.node_type );
> 		goto Exit;
> 	}
> 
>@@ -952,7 +952,7 @@ __osm_vendor_recv_dummy_cb(
> 	IN void *bind_context,
> 	IN osm_madw_t *p_req_madw )
> {
>-	printf("Ignoring received MAD after osm_vendor_unbind\n");
>+	fprintf(stderr, "__osm_vendor_recv_dummy_cb: Ignoring received MAD after osm_vendor_unbind\n");
> }
> 
> /**********************************************************************
>@@ -962,7 +962,7 @@ __osm_vendor_send_err_dummy_cb(
> 	IN void* bind_context,
> 	IN osm_madw_t *p_req_madw )
> {
>-	printf("Ignoring send error after osm_vendor_unbind\n");
>+	fprintf(stderr, "__osm_vendor_send_err_dummy_cb: Ignoring send error after osm_vendor_unbind\n");
> }
> 
> /**********************************************************************
>
>
>
>
>_______________________________________________
>openib-general mailing list
>openib-general at openib.org
>http://openib.org/mailman/listinfo/openib-general
>
>To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
>  
>





More information about the general mailing list