[openib-general] [RFC] [PATCH 2/7] ib_multicast 2.6.20: add ib_multicast module to track join requests from the same port

Sean Hefty mshefty at ichips.intel.com
Wed Oct 11 09:32:31 PDT 2006


Michael S. Tsirkin wrote:
> We already do state tracking to join/leave groups properly.
> It would be easier to review this change if you left killing off
> mcast->done and other such improvements for a separate patch.

The multicast module does reference counting and completion handling for us. 
Migrating ipoib to use ib_multicast, but keeping unnecessary duplicated 
functionality around in ipoib doesn't make sense.  Also, the callback can be 
invoked multiple times, so a 'done' flag isn't useful to track if the callback 
has been invoked.

- Sean




More information about the general mailing list