[openib-general] [PATCH] [RFC] cma_new_id can kfree on error instead of destroy_id

Sean Hefty mshefty at ichips.intel.com
Tue Oct 17 10:20:17 PDT 2006


Krishna Kumar wrote:
> cma_new_id() does not require to do destroy_id(), instead
> it can kfree(), since nothing is allocated on that id.
> Posting this as an RFC in case anyone feels that create_id
> should be cleaned up by destroy_id (even if redundant).

I can go either way on this.  It's a little cleaner to match rdma_create_id() 
with rdma_destroy_id(), rather than matching it with kfree().  It makes 
maintenance easier.

- Sean




More information about the general mailing list