[openib-general] [PATCH] Fix some cancellation problems in process_req().

Sean Hefty mshefty at ichips.intel.com
Thu Oct 19 08:17:07 PDT 2006


Krishna Kumar2 wrote:

> I felt that since the time_after() check matched (in all likelyhood) due 
> to the
> processing of the cancellation, ECANCELLED is more appropriate to return.
> It is most likely that if both conditions are true, that a cancelled 
> operation led to
> the time_after() match (cancel sets time to jiffies resulting in this 
> time_after match).
> Chances of both happening together is almost zero.
> 
> Do you agree ? Otherwise I can re-work the patch as suggested.

The only thing I would change about your patch is the if check as indicated.

- Sean




More information about the general mailing list