[openib-general] A question about sa_query

[Hal Rosenstock]

Ishai,

On Sun, 2006-10-22 at 11:15, Ishai Rabinovitz wrote:
> Hi,
> 
> There is something that bothers me in sa_query.
>  
> According to table 115 in the IB-SPEC when the status in the MAD hdr is 
> 1,2 or 3 it shouldn't be considered to as an error. (1 means busy, 2 
> means redirection, and 3 means both).

Yes, in fact the description of these bits in the table you mention
clearly says these are not errors.

> The function "recv_handler" in core/sa_query.c sets the status of the 
> sa_query before calling the callback function.
> It sets the status according to the status returned in the mad header. 
> (mad_recv_wc->recv_buf.mad->mad_hdr.status)
>  
> If the status in the mad_hdr is different from 0 it sets the return 
> status to -EINVAL.
>  
> This mean that the higher layers (e.g., SRP) do not know what was the 
> exact status and therefore treat status 1 (busy) as an error.

That appears to me to be the case and should be changed.

-- Hal

> Am I missing something?
>  
> Ishai