[openib-general] [PATCH] opensm: updn: make local functions static + local types

[Hal Rosenstock]

On Thu, 2006-10-19 at 17:26, Sasha Khapyorsky wrote:
> This makes local functions static and moves definitions of locally used
> types to .c file.
> 
> Signed-off-by: Sasha Khapyorsky <sashak at voltaire.com>
> ---
>  osm/include/opensm/osm_opensm.h     |    1 -
>  osm/include/opensm/osm_ucast_updn.h |  349 -----------------------------------
>  osm/opensm/osm_ucast_updn.c         |   81 +++++++-
>  3 files changed, 70 insertions(+), 361 deletions(-)

Thanks. Applied with some cosmetic changes.

Also, despite agreeing that it should be done, I did add __ in front of
those local osm_ functions in the interest of moving on and temporarily
ending the bickering. These are purely cosmetic and will hopefully
disappear if ever there will be agreement on either making incremental
changes in an incremental way or a wholesale updated coding style but
given that we cannot come to any common ground, I remain highly
skeptical on this.

-- Hal